[ 
https://issues.apache.org/jira/browse/BEAM-2939?focusedWorklogId=441997&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441997
 ]

ASF GitHub Bot logged work on BEAM-2939:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Jun/20 19:06
            Start Date: 05/Jun/20 19:06
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #11922:
URL: https://github.com/apache/beam/pull/11922#discussion_r436112241



##########
File path: 
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##########
@@ -941,20 +1047,59 @@ private Progress getProgress() {
           convertSplitResultToWindowedSplitResult.apply(result, 
watermarkAndState.getValue());
     }
 
+    List<BundleApplication> primaryRoots = new ArrayList<>();

Review comment:
       Yes. As shown in the test the self checkpoint will checkpoint for the 
"remaining" windows as well.
   
   I would like to leave it as is until we can build consensus around what we 
should do in these use cases.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 441997)
    Time Spent: 37h 20m  (was: 37h 10m)

> Fn API SDF support
> ------------------
>
>                 Key: BEAM-2939
>                 URL: https://issues.apache.org/jira/browse/BEAM-2939
>             Project: Beam
>          Issue Type: Improvement
>          Components: beam-model
>            Reporter: Henning Rohde
>            Assignee: Luke Cwik
>            Priority: P2
>              Labels: portability, stale-assigned
>          Time Spent: 37h 20m
>  Remaining Estimate: 0h
>
> The Fn API should support streaming SDF. Detailed design TBD.
> Once design is ready, expand subtasks similarly to BEAM-2822.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to