[
https://issues.apache.org/jira/browse/BEAM-10201?focusedWorklogId=444053&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-444053
]
ASF GitHub Bot logged work on BEAM-10201:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jun/20 00:01
Start Date: 11/Jun/20 00:01
Worklog Time Spent: 10m
Work Description: rezarokni commented on a change in pull request #11929:
URL: https://github.com/apache/beam/pull/11929#discussion_r438470939
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/JsonToRow.java
##########
@@ -72,10 +79,44 @@
@Experimental(Kind.SCHEMAS)
public class JsonToRow {
+ private static final String LINE_FIELD_NAME = "line";
+ private static final String ERROR_FIELD_NAME = "err";
+
+ public static final Schema ERROR_ROW_SCHEMA =
+ Schema.of(
+ Field.of(LINE_FIELD_NAME, FieldType.STRING),
+ Field.of(ERROR_FIELD_NAME, FieldType.STRING));
+
+ public static final TupleTag<Row> MAIN_TUPLE_TAG = new TupleTag<Row>() {};
+ public static final TupleTag<Row> DEAD_LETTER_TUPLE_TAG = new
TupleTag<Row>() {};
+
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 444053)
Time Spent: 2h 20m (was: 2h 10m)
> Enhance JsonToRow to add Deadletter Support
> -------------------------------------------
>
> Key: BEAM-10201
> URL: https://issues.apache.org/jira/browse/BEAM-10201
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Reza ardeshir rokni
> Priority: P2
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Current JsonToRow transform does not support Dead Letter pattern on parse
> failures.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
