[
https://issues.apache.org/jira/browse/BEAM-10153?focusedWorklogId=447893&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-447893
]
ASF GitHub Bot logged work on BEAM-10153:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jun/20 16:09
Start Date: 18/Jun/20 16:09
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #12029:
URL: https://github.com/apache/beam/pull/12029#discussion_r442337367
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/FnApiStateAccessor.java
##########
@@ -128,7 +128,7 @@ public FnApiStateAccessor(
@Override
public ResultT get() {
ArgT currentArg = arg.get();
- if (currentArg != memoizedArg) {
+ if (currentArg != memoizedArg || currentArg == null) {
Review comment:
This will require calling the function everytime when it is null.
You should use a boolean and update the check to be something like:
`(currentArg != memoizedArg || !initialized)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 447893)
Time Spent: 1h (was: 50m)
> Java SDK Harness throws NPE for VoidCoder as key coder
> ------------------------------------------------------
>
> Key: BEAM-10153
> URL: https://issues.apache.org/jira/browse/BEAM-10153
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-harness
> Reporter: Yichi Zhang
> Priority: P2
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When using VoidCoder as the key coder, NullPointerException will be thrown
> for processing element.
> {code:java}
> java.lang.NullPointerException
> at
> org.apache.beam.model.fnexecution.v1.BeamFnApi$StateKey$BagUserState$Builder.setKey(BeamFnApi.java:39390)
> at
> org.apache.beam.fn.harness.state.FnApiStateAccessor.createBagUserStateKey(FnApiStateAccessor.java:444)
> at
> org.apache.beam.fn.harness.state.FnApiStateAccessor.bindValue(FnApiStateAccessor.java:195)
> at
> org.apache.beam.sdk.state.StateSpecs$ValueStateSpec.bind(StateSpecs.java:327)
> at
> org.apache.beam.sdk.state.StateSpecs$ValueStateSpec.bind(StateSpecs.java:317)
> at
> org.apache.beam.fn.harness.FnApiDoFnRunner$ProcessBundleContext.state(FnApiDoFnRunner.java:1432)
> at
> org.apache.beam.sdk.transforms.ParDoTest$TimerTests$TwoTimerTest$1$DoFnInvoker.invokeProcessElement(Unknown
> Source)
> at
> org.apache.beam.fn.harness.FnApiDoFnRunner.processElementForParDo(FnApiDoFnRunner.java:740)
> at
> org.apache.beam.fn.harness.FnApiDoFnRunner.access$700(FnApiDoFnRunner.java:132)
> at
> org.apache.beam.fn.harness.FnApiDoFnRunner$Factory.lambda$createRunnerForPTransform$1(FnApiDoFnRunner.java:203)
> at
> org.apache.beam.fn.harness.data.PCollectionConsumerRegistry$MetricTrackingFnDataReceiver.accept(PCollectionConsumerRegistry.java:216)
> at
> org.apache.beam.fn.harness.data.PCollectionConsumerRegistry$MetricTrackingFnDataReceiver.accept(PCollectionConsumerRegistry.java:179)
> at
> org.apache.beam.fn.harness.BeamFnDataReadRunner.forwardElementToConsumer(BeamFnDataReadRunner.java:204)
> at
> org.apache.beam.fn.harness.data.QueueingBeamFnDataClient.drainAndBlock(QueueingBeamFnDataClient.java:106)
> at
> org.apache.beam.fn.harness.control.ProcessBundleHandler.processBundle(ProcessBundleHandler.java:295)
> at
> org.apache.beam.fn.harness.control.BeamFnControlClient.delegateOnInstructionRequestType(BeamFnControlClient.java:173)
> at
> org.apache.beam.fn.harness.control.BeamFnControlClient.lambda$processInstructionRequests$0(BeamFnControlClient.java:157)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> This fails validate runner tests such as
> https://github.com/apache/beam/blob/03d99dfa359f44a29a772fcc8ec8b0a237cab113/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java#L4120
> on dataflow runner with beam_fn_api.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
