ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto
replication should honor ensemble placement policy
URL: https://github.com/apache/bookkeeper/pull/641#discussion_r145502271
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
##########
@@ -810,47 +780,71 @@ public void openComplete(int newrc, final LedgerHandle
newlh, Object newctx) {
*/
for (final Long startEntryId : ledgerFragmentsToRecover) {
Long endEntryId = ledgerFragmentsRange.get(startEntryId);
- BookieSocketAddress newBookie = null;
+ ArrayList<BookieSocketAddress> ensemble =
lh.getLedgerMetadata().getEnsembles().get(startEntryId);
+ // Get bookies to replace
+ Map<Integer, BookieSocketAddress> targetBookieAddresses;
try {
- newBookie =
getNewBookie(lh.getLedgerMetadata().getEnsembles().get(startEntryId),
- availableBookies);
- } catch (BKException.BKNotEnoughBookiesException bke) {
-
ledgerFragmentsMcb.processResult(BKException.Code.NotEnoughBookiesException,
- null, null);
+ targetBookieAddresses = getReplacedBookies(lh,
ensemble, bookiesSrc);
Review comment:
getReplacedBookies -> getReplacementBookies
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
