eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145634367
########## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ########## @@ -136,6 +147,11 @@ message GetBookieInfoRequest { optional int64 requested = 1; } +message SyncRequest { + required int64 ledgerId = 1; Review comment: because this API means 'force and wait for a sync on data for the given ledger" A bookie has several journals and we want to fsync data only on the journal assigned to the ledger (just for an example). If you do not have "journal" with this primitive the clients want the bookie to acknowledge that data sent to him for the ledger has been persisted durably ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services