merlimat commented on a change in pull request #657: Use hash set with native
ints for write set tracking
URL: https://github.com/apache/bookkeeper/pull/657#discussion_r146706531
##########
File path: bookkeeper-server/pom.xml
##########
@@ -178,6 +178,11 @@
<artifactId>http-server</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.carrotsearch</groupId>
Review comment:
> Do you have checked license for this?
License is Apache v2.
> I am not sure what would be the benefits of using IntArrayList. If boxing,
unboxing Integer and using an ArrayList is a problem, why can't we use int[]
because we don't need resizing ability? we can wrap int[] into a recycle class,
it should be simple and efficient, no?
Yes, basically the class is a wrapper on top of an `int[]`. I guess the
option here would be to either reimplement the "set" logic on the `int[]` or
maybe import just the needed class.
> We already have several custom collections, maybe we could have our own
implementation of IntArrayList without importing a whole third party lib
Yes, the other collections were more about having no-boxing and concurrent
collections. For non-concurrent primitive collections there are many available
implementations (like the HPPC here).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
