ivankelly commented on a change in pull request #1298: newOpenLedgerOp and
ReadHandle implementation for MockBookKeeper
URL: https://github.com/apache/bookkeeper/pull/1298#discussion_r178840303
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockLedgerHandle.java
##########
@@ -100,7 +108,7 @@ public void run() {
final Queue<LedgerEntry> seq = new ArrayDeque<LedgerEntry>();
long entryId = firstEntry;
while (entryId <= lastEntry && entryId < entries.size()) {
- seq.add(entries.get((int) entryId++));
+ seq.add(new LedgerEntry(entries.get((int)
entryId++).duplicate()));
Review comment:
Pretty sure I saw issues without the duplicate, but can't test now since
pulsar master seems broken on OrderedExecutor stuff. Removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
