jvrao commented on a change in pull request #1393: BP-14 forceLedger wire
protocol server side implementation
URL: https://github.com/apache/bookkeeper/pull/1393#discussion_r186941208
##########
File path: bookkeeper-proto/src/main/proto/BookkeeperProtocol.proto
##########
@@ -63,6 +63,7 @@ enum OperationType {
READ_LAC = 7;
GET_BOOKIE_INFO = 8;
START_TLS = 9;
+ FORCE_LEDGER = 10;
Review comment:
I thought we are using SYNC_LEDGER instead of FORCE. Force doesn't tell what
it is forcing. I was feeling weird in the previous patch itself but did not
click on what it was I was missing in the name. :) s/force/sync makes lot of
sense and code readability IMO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
