ivankelly commented on a change in pull request #1642: Utility to rebuild
interleaved storage index files
URL: https://github.com/apache/bookkeeper/pull/1642#discussion_r215209993
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
##########
@@ -666,6 +659,15 @@ public Bookie(ServerConfiguration conf, StatsLogger
statsLogger)
this.ledgerMonitor = new LedgerDirsMonitor(conf, diskChecker,
ledgerDirsManager);
try {
this.ledgerMonitor.init();
+
+ // if the index and ledger are sharing directories we can use the
same monitor,
Review comment:
Ah, will change. Really we should only have one ledger dirs monitor which
can take a set of dir managers. Really it's just a thread and a little bit of
logic wrapping the dir. Out of scope for this change anyhow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
