sijie commented on a change in pull request #1949: [bookie-gc] add option to
cache entry-log metadata map into rocksDB
URL: https://github.com/apache/bookkeeper/pull/1949#discussion_r268477483
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
##########
@@ -104,6 +105,8 @@
protected static final String GC_OVERREPLICATED_LEDGER_WAIT_TIME =
"gcOverreplicatedLedgerWaitTime";
protected static final String USE_TRANSACTIONAL_COMPACTION =
"useTransactionalCompaction";
protected static final String VERIFY_METADATA_ON_GC = "verifyMetadataOnGC";
+ protected static final String GC_PERSISTENT_ENTRYLOGMETADATA_MAP_ENABLED =
"gcPersistentEntrylogMetadataMapEnabled";
Review comment:
I think a better name for these two settings would be:
`entryLogMetadataCacheEnabled` and `entryLogMetadataCachePath`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
