ivankelly commented on a change in pull request #2051: Cancel LAC watch when
longpoll LAC times out
URL: https://github.com/apache/bookkeeper/pull/2051#discussion_r271620968
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/LongPollReadEntryProcessorV3.java
##########
@@ -163,9 +163,10 @@ private ReadResponse getLongPollReadResponse() {
}
synchronized (this) {
expirationTimerTask = requestTimer.newTimeout(timeout -> {
- // When the timeout expires just get whatever is the
current
- // readLastConfirmed
-
LongPollReadEntryProcessorV3.this.scheduleDeferredRead(true);
+
requestProcessor.bookie.cancelWaitForLastAddConfirmedUpdate(ledgerId, this);
Review comment:
@eolivelli yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
