Q1ngbo opened a new issue, #3046: URL: https://github.com/apache/brpc/issues/3046
**Is your feature request related to a problem?** Hi, I noticed that while brpc supports CRC checks, it currently doesn't validate the attachment field. In some cases, users put important payloads in attachments, so adding CRC for them could improve data integrity. I looked into the implementation and it seems not difficult to support. If this feature is considered useful, I’d be happy to work on a patch. Thanks! **Describe the solution you'd like** I suggest extending the existing CRC mechanism with two FLAGS: 1. brpc_checksum: enables CRC validation at the brpc layer. When enabled, only the message will be validated. 2. brpc_checksum_attachment: when enabled alongside brpc_checksum, CRC validation will also include the attachment field. The checksum for the attachment can be computed by reusing the intermediate CRC state from the message part, so that the existing checksum_value field in the RPC meta can still be used without protocol changes. **Describe alternatives you've considered** **Additional context/screenshots** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
