GitHub user wwbmmm added a comment to the discussion: Workflow changes when new feature is added
Hello, I've seen your repository. My main question is, how are the `src/brpc/couchbase.h` and `src/brpc/couchbase.cpp` files you implemented related to brpc? It seems they only use the brpc namespace, while the rest of the code is independent. If that's the case, why were they placed in the brpc repository? Can you describe your use case scenario? Are you hoping to access couchbase servers through a brpc client to leverage advanced features like service discovery, load balancing, timeout and retry policies? If so, your current implementation does not fully meet the requirements, as it does not truly integrate the brpc client with the couchbase protocol. If you want the brpc client to support the couchbase protocol, you can refer to the implementation of the [memcached protocol](https://github.com/apache/brpc/blob/master/src/brpc/policy/memcache_binary_protocol.cpp) in brpc. The core task is to implement the serialization and deserialization of the protocol without introducing any external dependencies. However, fully supporting the couchbase protocol may involve a significant amount of work. I am not familiar with couchbase, it seems that the servers are stateful and the client needs to select the server based on the query, that would be quite complex. You could refer to [the PR for brp c's support of Redis Cluster](https://github.com/apache/brpc/pull/2228) , which has not yet been merged. If the servers are stateless and the client only needs to randomly select a couchbase server, it would be much simpler. GitHub link: https://github.com/apache/brpc/discussions/3085#discussioncomment-14361910 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
