[ 
https://issues.apache.org/jira/browse/CALCITE-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036354#comment-15036354
 ] 

Vladimir Sitnikov commented on CALCITE-999:
-------------------------------------------

{quote} I believe that ubenchmark MUST remain at source and target 1.6; {quote}
That's not a requirement.
Well, it would be nice to be able to build via different JDK versions (e.g. to 
compare performance of Calcite under different JDKs).


[~julianhyde],
It makes sense to update `maven-source-plugin` to disable default 
`attach-sources` goal.
Current configuration (in 816 branch) is bad: 
https://github.com/julianhyde/calcite/blob/816-sub-query/pom.xml#L327-L337

I believe it causes "double-execution of mvn generate-source" target during a 
release.
Here's detailed explanation: 
http://blog.peterlynch.ca/2010/05/maven-how-to-prevent-generate-sources.html
It boils down to "add invalid <phase> for default attach-sources execution id" 
and "add your own attach-sources-nofork".




> clean up all module pom.xml
> ---------------------------
>
>                 Key: CALCITE-999
>                 URL: https://issues.apache.org/jira/browse/CALCITE-999
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Sree Vaddi
>            Assignee: Julian Hyde
>         Attachments: Screen Shot 2015-12-02 at 08.35.45.png
>
>
> - all repository entries should go to parent pom
> - define versions in the parent pom; as possible
> - define plugins in the parent pom; as possible
> - define lifecycles in the parent pom; as possible
> - fix java versions (1.5, 1.6. 1.7 to 1.8)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to