[ 
https://issues.apache.org/jira/browse/CALCITE-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226533#comment-15226533
 ] 

Maryann Xue commented on CALCITE-1182:
--------------------------------------

Thank you, [~julianhyde], for the comments! I will make changes accordingly. 
One more question: Since the Operand.isWeaker() method is only called by 
ProjectToProjectUnifyRule1, would it be OK that we remove this method and make 
ProjectToProjectUnifyRule1 call SubstitutionVisitor.isWeaker(MutableRel, 
MutableRel) instead, like the other two rules do?

> Add ProjectRemoveRule to pre-processing program of materialization 
> substitution
> -------------------------------------------------------------------------------
>
>                 Key: CALCITE-1182
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1182
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Maryann Xue
>            Assignee: Maryann Xue
>            Priority: Minor
>              Labels: materializedviews, phoenix
>
> In VolcanoPlanner, we apply a simple pre-processing hep program to normalize 
> the "target" and "query" rels before materialization substitution. Currently 
> this program runs with two rules: FilterProjectTransposeRule and 
> ProjectMergeRule.
> We need an extra rule ProjectRemoveRule for the Phoenix use case where a 
> secondary index (modeled as materialized views) is defined on a view so the 
> materialized view "queryRel" may have an identity projection introduced by 
> this view.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to