[ 
https://issues.apache.org/jira/browse/CALCITE-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235612#comment-15235612
 ] 

Venki Korukanti commented on CALCITE-1177:
------------------------------------------

Hi [~julianhyde], Rebased the patch to just after the last release of Calcite. 
[Here|https://github.com/vkorukanti/calcite/commits/CALCITE-1177] are the new 
changes. While writing the tests for 
{{SqlOperatorBaseTest.testFloorFuncInterval}}, I realized convertlet for 
functions extract, floor and ceil is out of sync with the supported time units. 
Some of the newly supported units may not rewritten in div and multiplication 
(ex. millennium depends on type of calendar). Should we leave the convertlet 
table as it is or implement for certain calendar (eg. ISO)?

> Add support for more time units in extract function
> ---------------------------------------------------
>
>                 Key: CALCITE-1177
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1177
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Venki Korukanti
>            Assignee: Julian Hyde
>
> Currently extract function support following units YEAR, MONTH, DAY, HOUR, 
> MINUTE, SECOND. Add support for more units: CENTURY, DECADE, DOW, DOY, EPOCH, 
> MILLENNIUM, QUARTER, WEEK.
> Definitions of these units is similar to Postgres: 
> http://www.postgresql.org/docs/9.1/static/functions-datetime.html#FUNCTIONS-DATETIME-EXTRACT



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to