[ 
https://issues.apache.org/jira/browse/CALCITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245812#comment-15245812
 ] 

Josh Elser commented on CALCITE-1192:
-------------------------------------

bq. For the bytes_value field, I believe it should be bytes_values as per

Ugh, that is extremely unfortunate. That's a typo in the proto definition, 
rather than a documentation issue. I'm not sure if that's something we can 
change without breaking protobuf compat, but that's going to be how I'd like to 
fix it.

bq. Also, I think it would be useful to have some notes regarding the time 
values, for example:

Ahh, I had added this for the JSON docs, but forgot to do it for the Protobuf 
docs. I will amend that.

> Document protobuf and json REP types with examples
> --------------------------------------------------
>
>                 Key: CALCITE-1192
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1192
>             Project: Calcite
>          Issue Type: Improvement
>          Components: avatica
>            Reporter: Francis Chuang
>            Assignee: Josh Elser
>             Fix For: avatica-1.8.0
>
>
> It would be nice to have the documentation for the Rep types here 
> (https://calcite.apache.org/docs/avatica_protobuf_reference.html#rep) 
> documented with examples to show what the serialized representation looks 
> like.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to