[ 
https://issues.apache.org/jira/browse/CALCITE-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289838#comment-15289838
 ] 

Josh Elser commented on CALCITE-1242:
-------------------------------------

bq. Can you remind me why there is a maximum maxRowCount? Could we just remove 
the limit? I'd rather not introduce configuration parameters.

I think it predates my involvement, actually. I always assumed it was there to 
prevent clients from specifying {{Long.MAX_VALUE}} and causing the server to 
run out of heap space. That's what influences my assumption that we have a 
configurable upper-bound on that limit (since it would be a case-by-case 
basis). When we start thinking about multi-tenancy some more, this becomes 
pretty important.

> Allow configuration of maximum allowed value for maxRowCount
> ------------------------------------------------------------
>
>                 Key: CALCITE-1242
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1242
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>            Reporter: Duo Xu
>            Assignee: Josh Elser
>             Fix For: avatica-1.9.0
>
>
> There are several APIs having the maxRowCount parameter. Currently this 
> setting is hard coded in Avatica as 100. So if the user set maxRowCount > 100 
> in PrepareAndExecuteRequest, for example, the server will still only return 
> 100 results. So the APIs are currently broken.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to