[ 
https://issues.apache.org/jira/browse/CALCITE-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392770#comment-15392770
 ] 

Gautam Kumar Parai commented on CALCITE-1321:
---------------------------------------------

[~jni] [~julianhyde] Thanks so much for the comments. I have updated the pull 
request to address them (https://github.com/apache/calcite/pull/257). 

Regarding [~julianhyde]]'s comment " "Called by builder; all values are in 
private final fields." is a good idea. Make it so." There are setter accessor 
methods in {code}SqlToRelConverter{code} which require {code}ConfigImpl{code} 
members to NOT be final.

> In-list to join optimization should have configurable in-list size 
> -------------------------------------------------------------------
>
>                 Key: CALCITE-1321
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1321
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Gautam Kumar Parai
>            Assignee: Gautam Kumar Parai
>
> We current have a default in-list size of 20. Instead of the magic number 20, 
> we should make this configurable.
> {code}
> select count(*) from table where col in 
> (1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to