[
https://issues.apache.org/jira/browse/CALCITE-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15471217#comment-15471217
]
Julian Hyde edited comment on CALCITE-1342 at 9/7/16 5:24 PM:
--------------------------------------------------------------
[~minjikim], When you mark a bug resolved, can you please also add a "Fixed in
..." comment so we can tie back to the source code change. It makes it much
easier for others to review. I usually paste in the commit URL from the email
sent by ASF's git-hook, and add a "thank you" if it is from a non-committer.
See CALCITE-1337 for an example.
was (Author: julianhyde):
[~minjikim], When you mark a bug resolved, can you please also add a "Fixed in
..." comment so we can tie back to the source code change. It makes it much
easier for others to review. I usually paste in the commit URL from the email
sent by ASF's git-hook. See CALCITE-1334 for an example.
> ProjectPusher should use rel factories when creating new rels, e.g.
> project/filter
> ----------------------------------------------------------------------------------
>
> Key: CALCITE-1342
> URL: https://issues.apache.org/jira/browse/CALCITE-1342
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: MinJi Kim
> Assignee: Julian Hyde
> Fix For: 1.9.0
>
>
> I was playing around with some new ideas in drill, and wanted to use
> ProjectPusher, which has a lot of useful utility functions. ProjectPusher
> returns new nodes, but they are LogicalProjects/LogicalFilters. It would be
> more useful if the user of ProjectPusher could specify the rel factories to
> use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
