[ 
https://issues.apache.org/jira/browse/CALCITE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723034#comment-15723034
 ] 

Julian Hyde commented on CALCITE-1526:
--------------------------------------

Agreed, probably no immediate benefit. But currently we have redundant code 
(similar looking switch statements) and at future they will diverge. After 
they've diverged, and one of them has been refactored, we may no longer be able 
to combine them. Classic technical debt.

> Use Strong to infer whether a predicate's inputs may be null
> ------------------------------------------------------------
>
>                 Key: CALCITE-1526
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1526
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>
> {{RexImplicationChecker}} must use 
> [Strong|https://calcite.apache.org/apidocs/org/apache/calcite/plan/Strong.html]
>  to infer whether a predicate's inputs may be null. In particular the code in 
> {{RexImplicationChecker.implies2}}.
> Also {{RelMdPredicates.projectPredicate}}.
> [~jcamachorodriguez], Could/should {{RexUtil.ExprSimplifier}} be using 
> {{Strong}}?
> Also, maybe, {{RexUtil.simplifyIs}}.
> Also, {{LogicVisitor}} might be able to deduce that an expression is never 
> null if certain input fields are not null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to