[ https://issues.apache.org/jira/browse/CALCITE-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729632#comment-15729632 ]
Julian Hyde commented on CALCITE-1527: -------------------------------------- Regarding {{INSERT (SELECT vx As Cx...)}}. Yes, that's dropped. In my view, {{Values}} is a core relational expression. (Every real language has literals, right?) If a particular SQL dialect doesn't support {{VALUES}} then we can work around it using {{SELECT ... UNION}} or something. Regarding {{input.asSelect()}} in {{UPDATE}} and {{DELETE}}. The constructor parameter for each requires a {{SqlSelect}} (not a {{VALUES}}, nor a {{UNION}}) because SQL {{UPDATE}} and {{DELETE}} syntax handle the source relational expression differently than {{INSERT}} does. I propose we leave it as {{asSelect}}. If you can find a test case that breaks this, bring it on! > Support DML in the JDBC adapter > ------------------------------- > > Key: CALCITE-1527 > URL: https://issues.apache.org/jira/browse/CALCITE-1527 > Project: Calcite > Issue Type: Bug > Components: jdbc-adapter > Reporter: Christian Tzolov > Assignee: Julian Hyde > > Currently the JDBC adapter does not support the DML operations: *INSERT*, > *DELETE* and *UPDATE*. > Solution needs to convert the parsed *Modify* and *Values* RelNodes into > *JdbcTableModify*, *JdbcValues* ... such and then in turn into corresponding > SqlInsert, SqlUpdate and SqlDelete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)