[ 
https://issues.apache.org/jira/browse/CALCITE-1110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15775301#comment-15775301
 ] 

Josh Elser commented on CALCITE-1110:
-------------------------------------

bq. One question - What's the best way to resolve this if we use avatica 1.8.0?

[~praveev] -- will give you an answer here, but, in the future, please use the 
mailing list for these types of questions.

I'm not sure there is a "best" :). There are multiple ways to approach this, it 
depends on how Druid.

Perhaps the "cleanest" is to create your own shaded Avatica artifact. 
Essentially, use the work in Avatica 1.9.0 as a base to create your own jar 
which has avatica and shaded Jackson, etc. This would mostly be copying and 
tweaking. This gives you the freedom to shade whatever is necessary for Druid 
(which I could not possibly know upstream of Druid).

I think https://www.elastic.co/blog/to-shade-or-not-to-shade does a good 
example of explaining this.

> remove or relocate shaded jackson in Avatica
> --------------------------------------------
>
>                 Key: CALCITE-1110
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1110
>             Project: Calcite
>          Issue Type: Improvement
>          Components: avatica
>    Affects Versions: 1.6.0, 1.5.0
>            Reporter: Kai Gülzau
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: avatica-1.9.0
>
>
> The avatica jar includes a shaded version of jackson under the original 
> package path.
> This shaded version interferes with other jackson versions in the classpath.
> Currently this prevents us from using jackson functionality which is only 
> implemented in newer versions.
> https://mail-archives.apache.org/mod_mbox/calcite-dev/201602.mbox/%3C977C7450-18F4-48E2-A970-69B7E3E1BD2C%40apache.org%3E
> {quote}
> Is it reasonable to have a maven profile that uses jackson as “provided”[1] 
> rather than shading? This would not be the default — the default would be 
> continue to use a shaded version of jackson (relocated to 
> org.apache.calcite.jackson, as Josh suggests) — but folks looking to embed 
> calcite/avatica in a container might appreciate a lighter weight option.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to