[
https://issues.apache.org/jira/browse/CALCITE-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15783741#comment-15783741
]
Julian Hyde commented on CALCITE-1551:
--------------------------------------
Looks basically good.
* Pig requires that the name of the aggregate is retained. Can you revert the
change you made to PigletTest and make sure it passes.
* Is there a really good reason why DEPTNO0 became DEPTNO9 in
RelOptRulesTest.xml? We'd like derived field names to be stable, otherwise this
change will break downstream projects.
* It doesn't look as if the set of strings is immutable. Specifically, in
{{RelBuilder#as}}. Could you use an {{ImmutableSet}}? If
{{Pair<ImmutableSet<String>, RelDataTypeField>}} is too verbose, create {{class
FrameField extends Pair<ImmutableSet<String>, RelDataTypeField>}}.
* The standard formatting (e.g. for multi-line strings and chained method
calls) is not to align, but indent 4. I am happy to fix these before I commit.
> RelBuilder's project() doesn't preserve alias
> ---------------------------------------------
>
> Key: CALCITE-1551
> URL: https://issues.apache.org/jira/browse/CALCITE-1551
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Jess Balint
> Assignee: Julian Hyde
> Priority: Minor
>
> The alias should be preserved by the project node, e.g.
> {code:java}
> .scan("EMP")
> .as("EMP_alias")
> .project(...) // resets alias to null
> .project(builder.field("EMP_alias", "DEPTNO")) // fails that no such alias
> exists
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
