[ 
https://issues.apache.org/jira/browse/CALCITE-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840837#comment-15840837
 ] 

Laurent Goujon commented on CALCITE-1606:
-----------------------------------------

I don't have strong opinion regarding moving these over to a different table, 
but since QUARTER was already present, it seemed logical to put them there too 
(I'm still struggling about finding what's standard or not). I also saw these 
functions being implemented by several databases too (at least for the main 
ones: YEAR/MONTH/DAY/HOUR/MINUTE/SECOND).

For the doc, I agree, range should be between 0 and 59, I'll fix it

I also agree for rewriteCall, I will remove it then rebasing against master

As of dow, I used the ODBC spec (since I'm focusing on the scalar function 
support), which is described here: 
https://msdn.microsoft.com/en-us/library/ms714639(v=vs.85).aspx. Looks like 
that's the convention used by several databases (mysql, sql server). Oracle and 
DB2 seems to no implement DOW as an argument to extract on the other hand. 

> Add missing support for datetime JDBC functions
> -----------------------------------------------
>
>                 Key: CALCITE-1606
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1606
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Laurent Goujon
>            Assignee: Julian Hyde
>            Priority: Minor
>
> Calcite advertises support for all datetime functions but implementations are 
> missing for some of them.
> Since Calcite already supports EXTRACT(timeUnit FROM datetime), support could 
> be added for the following functions: YEAR, MONTH, WEEK, DAYOFYEAR, 
> DAYOFMONTH, DAYOFWEEK, HOUR, MINUTE, SECOND.
> Some concrete implementation (like WEEK) would be missing, but if RexImpTable 
> is updated to support it, then it would be fully wired.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to