[ 
https://issues.apache.org/jira/browse/CALCITE-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871829#comment-15871829
 ] 

Anton Mushin edited comment on CALCITE-1621 at 2/17/17 1:16 PM:
----------------------------------------------------------------

Hello [~julianhyde],
I updated PR. I added test cases for cast in 
{{AggregateExpandDistinctAggregatesRule}} and {{AggregateReduceFunctionsRule}}.
I don't know how I can check cast null literal in {{AggregateValuesRule}} 
because the rule works with result null literal and I get 
{noformat}LogicalValues(tuples=[[{ 0, null }]]){noformat}in result plan for 
{{select count(*), sum(empno) from emp where false}}


was (Author: anmu):
Hello [~julianhyde],
I updated PR. I added test cases for cast in 
{{AggregateExpandDistinctAggregatesRule}} and {{AggregateReduceFunctionsRule}}.
I don't know how I can check cast null literal in {{AggregateValuesRule}} 
because the rule works with result null literal and I get 
{noformat}LogicalValues(tuples=[[{ 0, null }]]){noformat}in result plan. 

> Adding a cast around the null literal in aggregate rules
> --------------------------------------------------------
>
>                 Key: CALCITE-1621
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1621
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.9.0
>            Reporter: Anton Mushin
>            Assignee: Julian Hyde
>
> [details in 
> mail|https://mail-archives.apache.org/mod_mbox/calcite-dev/201702.mbox/%3CBE6B5F8C-5F10-4394-8A6E-E5D0112B7BFF%40apache.org%3E]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to