[ 
https://issues.apache.org/jira/browse/CALCITE-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905525#comment-15905525
 ] 

Julian Hyde commented on CALCITE-1684:
--------------------------------------

[~kliew], [~jamestaylor], I would like to commit this change for 1.12. Can you 
let me know whether my proposal - to set the precision to -1, not 
Integer.MAX_VALUE - will meet Phoenix's needs. Integer.MAX_VALUE is a somewhat 
arbitrary value that might make sense for Phoenix but doesn't make sense for 
other DBs.

> Set the precision for VARCHAR and VARBINARY to the maximum value when not 
> specified
> -----------------------------------------------------------------------------------
>
>                 Key: CALCITE-1684
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1684
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.11.0
>            Reporter: Kevin Liew
>            Assignee: Julian Hyde
>            Priority: Minor
>             Fix For: 1.12.0
>
>
> The behavior for Calcite (and SQL Server) is to set {{VARCHAR}} precision to 
> {{1}} when not specified whereas Phoenix sets the max integer value of 
> {{2147483647}}.
> It doesn't really make sense to create a {{VARCHAR}} for a max length of 
> {{1}} (it takes more bytes to store the length of each row than the actual 
> value) and it shouldn't be the default behavior. I think we should adopt the 
> Phoenix behavior. Do we need to make this configurable via SqlConformance or 
> other?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to