[ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959166#comment-15959166
 ] 

ASF GitHub Bot commented on CALCITE-1364:
-----------------------------------------

Github user risdenk commented on a diff in the pull request:

    https://github.com/apache/calcite-avatica/pull/3#discussion_r110199982
  
    --- Diff: docker/src/main/docker/postgresql/Dockerfile ---
    @@ -0,0 +1,24 @@
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to you under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +# http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +
    +FROM avatica-server:latest
    +MAINTAINER Apache Avatica <d...@calcite.apache.org>
    +
    +# Dependencies
    +ADD 
https://repo1.maven.org/maven2/org/postgresql/postgresql/42.0.0.jre7/postgresql-42.0.0.jre7.jar
 /home/avatica/classpath/
    --- End diff --
    
    It looks like the difference between 42.0.0.jre7 and 42.0.0 is the level of 
the JDBC driver. Either JDBC 4.2 vs JDBC 4.1.


> Bring Docker image for avatica-standalone-server into Apache
> ------------------------------------------------------------
>
>                 Key: CALCITE-1364
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1364
>             Project: Calcite
>          Issue Type: Task
>          Components: avatica
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: avatica-1.10.0
>
>
> I worked on making some Docker images for the standalone Avatica Server with 
> HSQLDB.
> https://hub.docker.com/r/joshelser/avatica-hsqldb/
> These greatly simplify running the Avatica TCK and also provide a portable 
> server that developers can use when testing custom Avatica clients.
> For >=1.9.0, we should an image into Avatica (upstream). There are a couple 
> of open questions on my mind already:
> 1. What are the release-ability concerns (do we provide SNAPSHOT Dockerfiles 
> but not built images as they may be interpreted as "releases")?
> 2. What ASF integrations exist (do we need to ask Infra for things?)
> 3. Are there any maven plugins we should consider for automation? 
> (https://github.com/spotify/docker-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to