[
https://issues.apache.org/jira/browse/CALCITE-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959976#comment-15959976
]
ASF GitHub Bot commented on CALCITE-1353:
-----------------------------------------
GitHub user joshelser opened a pull request:
https://github.com/apache/calcite-avatica/pull/5
[CALCITE-1353] Convert first_frame_max_size to an int32
A uint64 is wrong because -1 is a valid value and Java can only
handle a max of 2**32, not 2**64, elements.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joshelser/calcite-avatica 1353-execute-request
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/calcite-avatica/pull/5.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5
----
commit 2b4762275c9833f305438a895dd8764f4f1b4d53
Author: Josh Elser <els...@apache.org>
Date: 2017-04-06T23:37:37Z
[CALCITE-1353] Convert first_frame_max_size to an int32
A uint64 is wrong because -1 is a valid value and Java can only
handle a max of 2**32, not 2**64, elements.
----
> first_frame_max_size in an ExecuteRequest should be an int32 in protobuf
> definitions.
> -------------------------------------------------------------------------------------
>
> Key: CALCITE-1353
> URL: https://issues.apache.org/jira/browse/CALCITE-1353
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Affects Versions: avatica-1.8.0
> Reporter: Francis Chuang
> Assignee: Josh Elser
> Priority: Minor
> Fix For: avatica-1.10.0
>
>
> In the protobuf definition for {{ExecuteRequest}}, the
> {{first_frame_max_size}} parameter is typed as an {{uint64}}. See
> https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L130.
> For consistency, it should be an {{int32}}.
> Similar parameters relating to the frame size are all typed as {{int32}}.
> For a {{PrepareAndExecuteRequest}}, {{first_frame_max_size}} is a{{int32}}:
> https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L78
> For a {{FetchRequest}}, {{frame_max_size}} is a {{int32}}:
> https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L96
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
