[
https://issues.apache.org/jira/browse/CALCITE-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033173#comment-16033173
]
Julian Hyde commented on CALCITE-1798:
--------------------------------------
Let's make a new JIRA case for this. This case is fixed already. I think
SqlNode.clone should remain shallow clone. Your proposed fix makes clone
sometimes deep, sometimes shallow. In fact I don't think we should alter clone
at all. My preferred solution would be to treat all SqlNodes as immutable
during this entire process, so if we to change anything, we have to create a
new copy.
> In JDBC adapter, generate dialect-specific SQL for FLOOR operator
> -----------------------------------------------------------------
>
> Key: CALCITE-1798
> URL: https://issues.apache.org/jira/browse/CALCITE-1798
> Project: Calcite
> Issue Type: Bug
> Components: jdbc-adapter
> Reporter: Chris Baynes
> Assignee: Julian Hyde
> Labels: dialect
> Fix For: 1.13.0
>
>
> The FLOOR operator (on dates) is currently broken for all jdbc dialects.
> The syntax allowed by the parser looks like: "FLOOR(datetime to timeUnit)".
> However no jdbc dialect (as far as I'm aware) actually name the function
> FLOOR:
> In postgres: DATE_TRUNC('year', my_datetime)
> In hsqldb: TRUNC ( my_datetime, 'YYYY' )
> In oracle: TRUNC(my_datetime, 'YEAR')
> In mysql: There's no direct equivalent in mysql (though it could be emulated
> with some nasty timestamp diffing)
> The other issue is that the timeUnits are sometimes also named differently by
> each dialect (e.g. 'YYYY' in hsqldb).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
