[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039593#comment-16039593 ]
slim bouguerra commented on CALCITE-1787: ----------------------------------------- my 2 cents. I think renaming is adding some complexity and the outcome is similar-ish to if we leave it as it is. I think going the route of udf is better as you can see per the sketch-hive docs https://datasketches.github.io/docs/Theta/ThetaHiveUDFs.html it is treated as UDF am assuming SQL/Hive users at Yahoo are already using those function so making calcite inline with this syntax will make perfect sense to me. > thetaSketch Support for Druid Adapter > ------------------------------------- > > Key: CALCITE-1787 > URL: https://issues.apache.org/jira/browse/CALCITE-1787 > Project: Calcite > Issue Type: New Feature > Components: druid > Affects Versions: 1.12.0 > Reporter: Zain Humayun > Assignee: Zain Humayun > Priority: Minor > > Currently, the Druid adapter does not support the > [thetaSketch|http://druid.io/docs/latest/development/extensions-core/datasketches-aggregators.html] > aggregate type, which is used to measure the cardinality of a column > quickly. Many Druid instances support theta sketches, so I think it would be > a nice feature to have. > I've been looking at the Druid adapter, and propose we add a new DruidType > called {{thetaSketch}} and then add logic in the {{getJsonAggregation}} > method in class {{DruidQuery}} to generate the {{thetaSketch}} aggregate. > This will require accessing information about the columns (what data type > they are) so that the thetaSketch aggregate is only produced if the column's > type is {{thetaSketch}}. > Also, I've noticed that a {{hyperUnique}} DruidType is currently defined, but > a {{hyperUnique}} aggregate is never produced. Since both are approximate > aggregators, I could also couple in the logic for {{hyperUnique}}. > I'd love to hear your thoughts on my approach, and any suggestions you have > for this feature. -- This message was sent by Atlassian JIRA (v6.3.15#6346)