[ https://issues.apache.org/jira/browse/CALCITE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126885#comment-16126885 ]
Dian Fu commented on CALCITE-1943: ---------------------------------- For {{NavigationExpander}}, currently I have not got a quite convincing explanation we should add it back. While for {{NavigationReplacer}}, I think it has its values. {{NavigationReplacer}} can convert expressions like {{A.price > PREV(B.price)}} to {{PREV(A.price, 0) > PREV(B.price, 1)}}. This will make the implementation unified: 1) step 1: RexPatternFieldRef A.price or B.price 2) step 2: RexCall (PREV) > Add back NavigationExpander and NavigationReplacer in SqlValidatorImpl > ---------------------------------------------------------------------- > > Key: CALCITE-1943 > URL: https://issues.apache.org/jira/browse/CALCITE-1943 > Project: Calcite > Issue Type: Bug > Reporter: Dian Fu > Assignee: Julian Hyde > > {{NavigationExpander}} and {{NavigationReplacer}} was deleted as a fix of > issue CALCITE-1871. Just create this ticket to track whether we should add > them back. -- This message was sent by Atlassian JIRA (v6.4.14#64029)