[ 
https://issues.apache.org/jira/browse/CALCITE-2059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356053#comment-16356053
 ] 

Julian Hyde commented on CALCITE-2059:
--------------------------------------

I've made some cosmetic changes; can you review and squash in 
https://github.com/julianhyde/calcite/tree/2059-geode.

Review comments:
 * Can you explain (in the javadoc preferably) why "GeodeAggregationSort" 
contains the word "Aggregation"? I imagine it's a Geode concept, but it is 
misleadingly similar to Calcite's "Aggregate" concept.
* In GeodeUtils, the fields REGION_MAP and JAVA_TYPE_FACTORY are a concern 
because they may cause a memory leak.
* If you intend to keep Main1Foo, can you give it a better name.

> Apache Geode adapter
> --------------------
>
>                 Key: CALCITE-2059
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2059
>             Project: Calcite
>          Issue Type: New Feature
>          Components: geode
>            Reporter: Christian Tzolov
>            Assignee: Julian Hyde
>            Priority: Major
>
> I've been working on a Calcite adapter for [Apache 
> Geode|http://geode.apache.org]. 
> Current implementation uses the plain Geode API and 
> [OQL|http://geode.apache.org/docs/guide/13/developing/querying_basics/chapter_overview.html](Object
>  Query Interface) to push down relational expressions such as projections, 
> filtering, sorting, and grouping . 
> Provided functionality can hopefully address certain Geode use cases and will 
> provide a stepping stone for future improvements. 
> Here are some remaining tasks as i see it:
> * New tests for test suite (and update calcite-test-dataset to support Geode)
> * Add Integration tests that use calcite-test-dataset
> * Documentation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to