[ 
https://issues.apache.org/jira/browse/CALCITE-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385021#comment-16385021
 ] 

Volodymyr Vysotskyi commented on CALCITE-2201:
----------------------------------------------

[~julianhyde], there is nothing special in this pull request, just added a 
possibility to pass custom {{RelBuilder}} into {{RelOptUtil}} and 
{{JoinCommuteRule}} and made deprecated old methods without {{RelBuilder}} in 
the arguments list (there are added/exist methods with the same list of 
arguments + {{RelBuilder}}).
In {{RelDecorrelator}} made changes to use passed {{RelBuilder}} in the rules 
which used in this class.
In {{RelStructuredTypeFlattener}} made changes to use "new" methods from 
{{RelOptUtil}}, etc...
Also, "mvn verify" succeed.

Please let me know if I should make some additional changes in this PR.

> Allow passing custom RelBuilder into RelDecorrelator and 
> RelStructuredTypeFlattener
> -----------------------------------------------------------------------------------
>
>                 Key: CALCITE-2201
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2201
>             Project: Calcite
>          Issue Type: Task
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Julian Hyde
>            Priority: Major
>
> When {{RelDecorrelator.decorrelateQuery()}} method is called, 
> {{RelDecorrelator}} instance with {{RelFactories.LOGICAL_BUILDER}} is 
> created. We should modify this method to allow usage of custom {{RelBuilder}}.
> Also, {{RelStructuredTypeFlattener}} class should be modified in a similar 
> way.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to