[ https://issues.apache.org/jira/browse/CALCITE-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453890#comment-16453890 ]
Zoltan Haindrich commented on CALCITE-2257: ------------------------------------------- [~vitalii]: I've tried to peek into this also...but it seems to me that {{x is null or x is not null}} should be true in 1.16; I'm not sure, but it might be possible that somehow {{ReduceExpressionsRule}} is not kicking in my branch where I've checked this: https://github.com/apache/calcite/compare/branch-1.16...kgyrtkirk:2257-b1.16-chk note: it seems to be possible to extend CALCITE-2247 to cover OR cases also > Combination of predicates can be proved to be always true > --------------------------------------------------------- > > Key: CALCITE-2257 > URL: https://issues.apache.org/jira/browse/CALCITE-2257 > Project: Calcite > Issue Type: Improvement > Components: core > Affects Versions: 1.16.0 > Reporter: Vitalii Diravka > Assignee: Vitalii Diravka > Priority: Major > Labels: filter > Fix For: 1.17.0 > > > I have found the case, when Filter operator is not necessary since filter > condition is always true, but that is not detected by current version of > Calcite. > {code} > select SAL from EMPNULLABLES_20 where SAL IS NOT NULL OR SAL is null > {code} > {code} > LogicalProject(SAL=[$5]) > LogicalFilter(condition=[OR(IS NOT NULL($5), IS NULL($5))]) > LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3], HIREDATE=[$4], > SAL=[$5], COMM=[$6], SLACKER=[$8]) > LogicalFilter(condition=[AND(=($7, 20), >($5, 1000))]) > LogicalTableScan(table=[[CATALOG, SALES, EMPNULLABLES]]) > {code} > But filter condition _OR(IS NOT NULL($5), IS NULL($5))_ can be proved to be > always true. > I have tried _ReduceExpressionsRule_, but it doesn't give effect. -- This message was sent by Atlassian JIRA (v7.6.3#76005)