[
https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481147#comment-16481147
]
Zoltan Haindrich commented on CALCITE-2247:
-------------------------------------------
I think that probably unknownAsFalse should be retired; because in case someone
would like that behaviour he could rewrite the input expression to (origExpr IS
TRUE) which is by my understanding would be "unknown as false"... but of
course; I might not see all use cases of it.
I've fixed {{(b!=1 || b==1)}} in the PR; actually it was just the removal of
the conditional whenever it's unknownAsFalse or not; and it uses nullability
correctly.
the same 32 tests fail with and without my patch on your branch.
> Add rule to push in condition condition into a related disjunctive expression
> -----------------------------------------------------------------------------
>
> Key: CALCITE-2247
> URL: https://issues.apache.org/jira/browse/CALCITE-2247
> Project: Calcite
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
>
> Simplify expressions like: {code}a = 1 AND (a = 1 OR a = 2){code} to {code}a
> = 1{code}
> Conditions to apply will be:
> * in an AND condition there exists a comparison(c) and an OR (o)
> * o and c only reference 1 variable
> See HIVE-19097 for more info.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
