[ https://issues.apache.org/jira/browse/CALCITE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495921#comment-16495921 ]
Laurent Goujon commented on CALCITE-2339: ----------------------------------------- {quote} Laurent Goujon, That would be quite a significant change, because DATETIME_PLUS only takes two arguments: a timestamp and an interval. And WEEK is not a supported unit of interval types. Are you proposing to add an extra parameter? {quote} Not an extra argument, but it looks like {{IntervalSqlType}} operand is derived from {{SqlIntervalQualifier}}, and that {{WEEK}} is could a possible interval qualifier (it looks like that {{SqlIntervalQualifier#typeName()}} returns more than just SQL intervals). So even if {{WEEK}} is not a valid interval type from a parsing/validation point of view, any drawback of creating a call with a {{WEEK}} {{IntervalSqlType}} operand in the convertlet? > JDBC adapter should transform timestamp arithmetic for target database > ----------------------------------------------------------------------- > > Key: CALCITE-2339 > URL: https://issues.apache.org/jira/browse/CALCITE-2339 > Project: Calcite > Issue Type: Bug > Reporter: Julian Hyde > Assignee: Julian Hyde > Priority: Major > Attachments: Datetime Addition - Calcite.pdf > > > JDBC adapter should transform timestamp arithmetic for target database. > There are two ways in Calcite to add intervals to timestamps: the > TIMESTAMP_ADD function and the "<timestamp> + <interval>" operator. > The attached document (authored by James Doung) describes their pros and cons. -- This message was sent by Atlassian JIRA (v7.6.3#76005)