[ 
https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500608#comment-16500608
 ] 

Julian Hyde commented on CALCITE-2345:
--------------------------------------

bq. How can I get zips data in unit test (classpath) ? Should it be separate 
artifact (maven central?) or somewhere in test/resources ? 

Easiest thing to start with is to copy-paste zips.json from 
https://github.com/vlsi/calcite-test-dataset/tree/master/zips/src/main/resources/dataset
 into Calcite. Maybe we can convert that to a maven resource later on.

bq. Both issues have similar goals: execute AdapterIT tests using in-memory 
fakes in addition to existing integration tests.

Yes, I would like to have integration tests in addition to tests against a fake 
database.

That said, I don't want to double the amount of test code that we have. (We 
have more test code for the Mongo adapter than the Calcite community is able to 
maintain; for instance,  existing tests have broken over time.) I would like to 
keep the existing tests and allow them to be run in two different ways. Maybe 
move the existing tests that are in MongoAdapterIT into a base class?

> add tests using Fongo to Mongo Adapter
> --------------------------------------
>
>                 Key: CALCITE-2345
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2345
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Andrei Sereda
>            Assignee: Michael Mior
>            Priority: Major
>
> Better test coverage for unit tests using 
> [Fongo|https://github.com/fakemongo/fongo] which is in-memory implementation 
> of Mongo API.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to