[
https://issues.apache.org/jira/browse/CALCITE-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505395#comment-16505395
]
ASF GitHub Bot commented on CALCITE-2322:
-----------------------------------------
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/calcite-avatica/pull/49#discussion_r193906310
--- Diff:
core/src/main/java/org/apache/calcite/avatica/AvaticaStatement.java ---
@@ -108,6 +109,7 @@ protected AvaticaStatement(AvaticaConnection connection,
this.resultSetType = resultSetType;
this.resultSetConcurrency = resultSetConcurrency;
this.resultSetHoldability = resultSetHoldability;
+ this.fetchSize = connection.config().fetchSize(); // Default to
connection config fetch size.
--- End diff --
the value is both set in the field declaration and in the constructor, just
suggesting to remove the default value in the field initialization...
> Add fetch size support to connection url and JDBC statement
> -----------------------------------------------------------
>
> Key: CALCITE-2322
> URL: https://issues.apache.org/jira/browse/CALCITE-2322
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.11.0
> Reporter: Kevin Minder
> Assignee: Julian Hyde
> Priority: Major
>
> Currently the remote driver defaults to hard coded fetch size of 100 rows.
> When a connection is operating in HTTP mode having such a small fetch size
> can add enormous overhead. This is especially true if TLS connections are
> used and made worse if each connection flows throw multiple proxies.
> Consider that 100K rows returned 100 rows at a time will make 1K HTTP POST
> requests. One might say that nobody should ever do that but some tools like
> Spotfire may end up doing this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
