[
https://issues.apache.org/jira/browse/CALCITE-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530275#comment-16530275
]
Julian Hyde commented on CALCITE-2363:
--------------------------------------
That seems like a good idea.
However, let's get another review before you start work on this. Ask on the dev
list for a reviewer.
> Refactor RelShuttle not to depend on structures of RelNodes
> -----------------------------------------------------------
>
> Key: CALCITE-2363
> URL: https://issues.apache.org/jira/browse/CALCITE-2363
> Project: Calcite
> Issue Type: Improvement
> Reporter: Teruyoshi Zenmyo
> Assignee: Julian Hyde
> Priority: Major
> Fix For: 1.17.0
>
>
> Currently, RelShuttle implementations depends on the structures of RelNodes.
> For instance, RelShuttleImp.visit(LogicalAggregate aggregate) knows the first
> element of getInput() is the next element to be visited.
> [https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/rel/RelShuttleImpl.java#L75]
>
> By this refactoring, implementations of RelShuttle will become free from
> invoking super.visit methods.
> https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql2rel/CorrelationReferenceFinder.java#L61
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
