[ https://issues.apache.org/jira/browse/CALCITE-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585636#comment-16585636 ]
Vladimir Sitnikov commented on CALCITE-2480: -------------------------------------------- [~julianhyde], is {{lowerName = name.toLowerCase(Locale.ROOT)}} required at all? It looks like just {{floor(name)}} + {{ceiling(name)}} is enough. > NameSet.contains wrongly returns false when element in set is upper-case and > seek is lower-case > ----------------------------------------------------------------------------------------------- > > Key: CALCITE-2480 > URL: https://issues.apache.org/jira/browse/CALCITE-2480 > Project: Calcite > Issue Type: Bug > Components: core > Reporter: Vladimir Sitnikov > Assignee: Julian Hyde > Priority: Major > Fix For: 1.18.0 > > > {code:java} @Test public void testNameSetContains() { > final NameSet names = new NameSet(); > names.add("COUNT"); > names.add("COVAR_POP"); > assertThat(names.contains("count", true), is(false)); > assertNsContains(names, "count", false, true); > } > private void assertNsContains(NameSet names, String item, boolean > caseSensitive, boolean result) { > assertEquals(names + ", contains(" + item + (caseSensitive ? ", > caseSensitive" : "") > + ")", > result, names.contains(item, caseSensitive)); > }{code} > Output > {noformat}java.lang.AssertionError: [COUNT, COVAR_POP], contains(count) > Expected :true > Actual :false{noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)