[
https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610077#comment-16610077
]
Hongze Zhang edited comment on CALCITE-2535 at 9/11/18 3:37 AM:
----------------------------------------------------------------
[~julianhyde]
Thanks for you explanation, But sorry for a little confused.
bq.In order to get those tests to pass we need to give functions the ability to
yield exceptions (search for "FNL-3" in the code).
At first I benefited from this suggestion cause I thought
ExceptionInInitializerError is not good for both use and test. For now if I am
not mistaken, I think that what you meant is to not to over optimize the
error(unwrap the error to an exception or move it to Enumerator::current)
because in real world the error would not be produced, only exceptions would be
thrown since data is from table. Please correct me If i guessed wrong.
And It would be great if I could get some information about he original propose
about the issue FNL-3. Is this issue about "move exception from const to
runtime invocation"?
was (Author: zhztheplayer):
[~julianhyde]
Thanks for you explanation, But sorry for a little confused.
bq.In order to get those tests to pass we need to give functions the ability to
yield exceptions (search for "FNL-3" in the code).
At first I benefited from this suggestion cause I thought
ExceptionInInitializerError is not good for both use and test. For now if I am
not mistaken, I think that what you meant is to not to over optimize the
error(unwrap the error to an exception or move it to Enumerator::current) so
that the test cases could easily detect possible exceptions even without
getting the enumerator running. Please correct me If i guessed wrong.
And It would be great if I could get some information about he original propose
about the issue FNL-3. Is this issue about "move exception from const to
runtime invocation"?
> Runtime failure check not working in SqlTesterImpl.java
> -------------------------------------------------------
>
> Key: CALCITE-2535
> URL: https://issues.apache.org/jira/browse/CALCITE-2535
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Hongze Zhang
> Assignee: Julian Hyde
> Priority: Major
>
> Problem at SqlTesterImpl#checkFails:
> When argument "runtime" is specified as true, error assertion and error
> message matching will not be performed.
> This issue could result in wrong test result in SqlOperatorBaseTest.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
