[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610161#comment-16610161 ]
Vladimir Sitnikov commented on CALCITE-2535: -------------------------------------------- [~zhztheplayer], while I agree there might be issues like "test should fail but wrongly passed", and it is great you want to fix/improve that. Juilan says that "exception handling" is tricky. And pease make sure that Calcite engine does not over-optimize. That is, there might be cases when "constant folder" would fold a computation that would never be triggered during normal query execution(without constant folder). The rule #1 is "optimizer must not convert good SQL to a failing one". > Runtime failure check not working in SqlTesterImpl.java > ------------------------------------------------------- > > Key: CALCITE-2535 > URL: https://issues.apache.org/jira/browse/CALCITE-2535 > Project: Calcite > Issue Type: Bug > Components: core > Reporter: Hongze Zhang > Assignee: Julian Hyde > Priority: Major > > Problem at SqlTesterImpl#checkFails: > When argument "runtime" is specified as true, error assertion and error > message matching will not be performed. > This issue could result in wrong test result in SqlOperatorBaseTest. -- This message was sent by Atlassian JIRA (v7.6.3#76005)