[ 
https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623992#comment-16623992
 ] 

Julian Hyde commented on CALCITE-2535:
--------------------------------------

[~zhztheplayer] Yes CALCITE-535 is perfect. I'll assign it to you.

Some sub-class of CalciteException that contains a 
org.apache.calcite.avatica.SqlState would be good. It should be a 
RuntimeException (unchecked). We can wrap it in a SQLException (checked) later.

Regarding 4. Create the exception, but don't throw it, call an exception 
handler. It will either throw it, or log it, or ignore it, depending on mode. 
For now, put this handler into a ThreadLocal. We might move it to DataContext 
later.

> Runtime failure check not working in SqlTesterImpl.java
> -------------------------------------------------------
>
>                 Key: CALCITE-2535
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2535
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Hongze Zhang
>            Assignee: Julian Hyde
>            Priority: Major
>             Fix For: 1.18.0
>
>
> Problem at SqlTesterImpl#checkFails:
> When argument "runtime" is specified as true, error assertion and error 
> message matching will not be performed.
> This issue could result in wrong test result in SqlOperatorBaseTest.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to