[ https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649073#comment-16649073 ]
Aman Sinha commented on CALCITE-2617: ------------------------------------- [~julianhyde], [~zabetak] if the tests pass with these changes (by using a separate constructor and passing in a predicate for checking correlation) I don't have an issue with it. There are 2 somewhat competing requirements. Ideally, I believe the decorrelator needs to be run again after the Filter pushdown has occurred (via FPTRule). > FilterProjectTransposeRule should allow filter conditions with correlated > variables to be pushed down > ----------------------------------------------------------------------------------------------------- > > Key: CALCITE-2617 > URL: https://issues.apache.org/jira/browse/CALCITE-2617 > Project: Calcite > Issue Type: Improvement > Components: core > Affects Versions: 1.17.0 > Reporter: Stamatis Zampetakis > Assignee: Julian Hyde > Priority: Major > Fix For: 1.18.0 > > > The rule always forbids conditions with correlated variables to be pushed > down (as of [CALCITE-769|https://issues.apache.org/jira/browse/CALCITE-769] > to avoid certain problems in the decorrelation of the query). However, in the > general context of query optimization, it is beneficial to push-down filters > and the fact that there is a correlated variable is not a reason to skip this > optimization. > In order to avoid regressions, and at the same time enable correlated > conditions to be pushed down we should make the pushing of correlated > variables configurable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)