[ 
https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652404#comment-16652404
 ] 

Daniel Lemire commented on CALCITE-2619:
----------------------------------------

As for validating UTF-8 bytes, @julianhyde is probably right that Guava is a 
good choice... if one cares about performance in this instance...

 

 

[https://lemire.me/blog/2018/10/16/validating-utf-8-bytes-java-edition/]

 

Note that their function is going to be super fast if the input is ASCII... so 
it is good.

 

The issue posted here is different. I think. Let me comment on that separately.

> Reduce string literal creation cost by removing charset check
> -------------------------------------------------------------
>
>                 Key: CALCITE-2619
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2619
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Ted Xu
>            Assignee: Julian Hyde
>            Priority: Major
>
> The cost of creating NlsString is very high, due to its charset check. In 
> some cases, e.g., expression evaluate because of Partition Prune, the 
> NlsString creation costs 40%+ of total executor's overhead.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to