[
https://issues.apache.org/jira/browse/CALCITE-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686454#comment-16686454
]
Jark Wu commented on CALCITE-1912:
----------------------------------
Hi [~julianhyde] , I have updated the PR and addressed the comments you left
above.
- Please document SQL syntax in reference.md
done
- Why the did error message change in lateral.iq?
I modified the syntax parse implementation in Parser.jj and passed the
lateral.iq test.
- Remove the commented-out lines in SqlValidatorImpl
done
- I think you should rename SqlTemporal to SqlSnapshot.
I agree with you. Done.
- Add a method RelBuilder.snapshot, and document it in algebra.md
done
- Rather than TemporalTableScan(table, period) I think you should have
Snapshot(TableScan(table), period)
done. The current implementation of Snapshot accepts a RelNode input, not
restrict to TableScan. I'm not sure whether it is good for now, as we want
Snapshot can apply to any relation.
Please feel free to leave you thoughts.
> Support "FOR SYSTEM_TIME AS OF" in regular queries
> --------------------------------------------------
>
> Key: CALCITE-1912
> URL: https://issues.apache.org/jira/browse/CALCITE-1912
> Project: Calcite
> Issue Type: New Feature
> Reporter: Jark Wu
> Assignee: Julian Hyde
> Priority: Major
> Fix For: 1.18.0
>
>
> As discussed in mailling list[1], we hope to support "FOR SYSTEM_TIME AS OF"
> in Calcite to retrieve table contents as of a given point in time.
> [1]
> https://lists.apache.org/thread.html/f877f356a8365bf74ea7d8e4a171224104d653cf73861afb2901a58f@%3Cdev.calcite.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
