[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699459#comment-16699459 ]
Julian Hyde commented on CALCITE-2662: -------------------------------------- Can you attach a link to the PR? If the PR is non-invasive I wouldn't strongly object to it. It may or may not improve performance significantly, but I acknowledge it would be convenient if people could parse a Reader. Can you add a test that error locations (line/column) work correctly. I suspect that this functionality uses a materialized string behind the scenes. > Planner: allow parsing directly a stream instead of a java.lang.String > ---------------------------------------------------------------------- > > Key: CALCITE-2662 > URL: https://issues.apache.org/jira/browse/CALCITE-2662 > Project: Calcite > Issue Type: Improvement > Components: core > Affects Versions: 1.17.0 > Reporter: Enrico Olivelli > Assignee: Julian Hyde > Priority: Major > > In 1.17.0 the org.apache.calcite.tools.Planner interface only accept a > java.lang.String as input. > In order to reduce memory allocations and copies it will be useful that the > planner could accept the query in a more 'raw' format. > Creating a java.lang.String is very expensive, and if your "query" is coming > from the network (think about a Netty Direct memory ByteBuf) you are forced > to create a copy of the text of the query. -- This message was sent by Atlassian JIRA (v7.6.3#76005)