[ 
https://issues.apache.org/jira/browse/CALCITE-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779142#comment-16779142
 ] 

Stamatis Zampetakis commented on CALCITE-2859:
----------------------------------------------

{quote}Regarding SaffronProperties. Can you deprecate it and add its 6 
properties allowInfiniteCostConverters, defaultCharset, defaultCollation, 
defaultCollationStrength, metadataHandlerCacheMaximumSize into 
CalciteSystemProperty. So, no code will be using SaffronProperties anymore. 
Keep the properties in the "saffron." namespace for now, but you can add a 
"calcite." alias if it's not too hard.
{quote}
I did what [~julianhyde] suggested and updated the PR. If nobody objects I will 
merge it tomorrow.

> Centralize Calcite system properties
> ------------------------------------
>
>                 Key: CALCITE-2859
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2859
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.18.0
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Trivial
>              Labels: pull-request-available
>             Fix For: 1.19.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently there are various system (jvm) properties exploited by Calcite 
> which are distributed all over the codebase. System properties are part of 
> the public API so they should be easily accessible and well documented. 
> The goal is to centralize all system properties with the "calcite" prefix 
> under a common class/interface/enum. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to