[ https://issues.apache.org/jira/browse/CALCITE-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812853#comment-16812853 ]
Francis Chuang edited comment on CALCITE-2882 at 4/8/19 10:44 PM: ------------------------------------------------------------------ [~shining] There are a few comments on your PR. Can you please have a look and address them? We are planning to make Avatica 1.14.0 available for voting soon, and I'd like to include this PR if possible. was (Author: francischuang): [~shining] There are a few comments on your PR. Can you please have a look and address them? > ConnectionProperties lose effectiveness when connection reopen after expired > ---------------------------------------------------------------------------- > > Key: CALCITE-2882 > URL: https://issues.apache.org/jira/browse/CALCITE-2882 > Project: Calcite > Issue Type: Bug > Components: avatica > Affects Versions: 1.12.0 > Environment: Phoenix 5.1 > avatca 1.12 > Reporter: shining > Priority: Major > Labels: pull-request-available > Attachments: image-2019-02-28-17-25-39-478.png, > image-2019-02-28-17-28-31-926.png > > Time Spent: 40m > Remaining Estimate: 0h > > When use avatica connect Phoenix QueryServer, I create an AvaticaConnection: > {code:java} > Connection conntion = DriverManage.getConnection(url); > connection.setAutoCommit(true); > {code} > Avatica keep PhoenixConnection alive in the Cache, which will be expired > after 10min by default. > I still use the older AvaticaConnection , it will reopen an > PhoenixConnection, but the ConnectionProperties is loss, such as AutoCommit. > I use sqlline-thin.py to reappear the problem: > 1) sqlline-thin.py http://localhost:8765 > 2) upsert one row and select > !image-2019-02-28-17-25-39-478.png! > 3) after 10 min, upsert again, the connection will be recreate, but select > null > !image-2019-02-28-17-28-31-926.png! > [link title|https://github.com/apache/calcite-avatica/pull/86] -- This message was sent by Atlassian JIRA (v7.6.3#76005)